New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abr-controller stops sampling throughput at download boundaries #3789
Comments
Does this issue only present when |
You absolutely should not enable |
Reproduced the issue and can see that this is an issue with the fetch loader which is selected by default when |
Hi Rob, Thank you for the explanation. It really helps. :) |
* 'master' of https://github.com/video-dev/hls.js: (327 commits) [skip netlify] Update dependency netlify-cli to v3.21.9 [skip netlify] Update dependency netlify-cli to v3.21.8 [skip netlify] Update dependency eslint to v7.25.0 [skip netlify] Update dependency netlify-cli to v3.21.7 [skip netlify] Update dependency netlify-cli to v3.21.5 [skip netlify] Update dependency netlify-cli to v3.21.3 [skip netlify] Update dependency netlify-cli to v3.21.2 [skip netlify] Update actions/github-script action to v4 (video-dev#3809) [skip netlify] Update dependency netlify-cli to v3.21.1 [skip netlify] Update dependency netlify-cli to v3.21.0 [skip netlify] Update babel monorepo to v7.13.16 [skip netlify] Update dependency netlify-cli to v3.20.1 [skip netlify] Update dependency netlify-cli to v3.19.1 [skip netlify] Update dependency @microsoft/api-extractor to v7.14.0 Fix fetch loader stats marked as aborted after loaded Fixes video-dev#3789 Evict unbuffered audio and main fragments from the tracker on BUFFER_FLUSHED Resolves video-dev#3770 Fix setInterval/Timer regression in fps-controller Fixes video-dev#3790 [skip netlify] Update dependency netlify-cli to v3.19.0 [skip netlify] Lock file maintenance [skip netlify] Lock file maintenance ... # Conflicts: # .gitignore
What version of Hls.js are you using?
v1.0.0 and v1.0.1
What browser and OS (including versions) are you using?
Google Chrome 89.0.4389.114
macOS 10.15.6
Test stream:
BBB: https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8
Akamai: https://ll-hls-test-apple.akamaized.net/cmaf/master.m3u8
Configuration:
Checklist
Steps to reproduce
Expected behavior
In abr-controller, each time
Events.FRAG_BUFFERED
is triggered, theonFragBuffered
function should sample and update throughput by callingthis.bwEstimator.sample
.Actual behavior
Most time
Events.FRAG_BUFFERED
is triggered, theonFragBuffered
function directly returns due tostats.aborted == True
.Temporary Solution
I used v1.0.0-rc.4 before and it works well.
So I compared all files manipulating flag
stats.aborted
with those from rc.4.Then I found that this bug can be solved by removing line 265
loader.destroy();
in src/loader/fragment-loader.ts.The text was updated successfully, but these errors were encountered: