-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Green artifacts when using hls.js on latest Chrome Mac OS X #676
Comments
I see garbled video in Firefox 51, Chrome 53, and Safari on OS X 10.11.6. |
I can repro in my browsers too. The stream seems ok; the only difference compared to streams which work in the same browsers is that display aspect ratio and average frame rate are not explicitly defined: ffprobe -v error -select_streams V -show_entries \
stream=display_aspect_ratio,r_frame_rate,avg_frame_rate \
'https://playback.drntruhs.in:8443/vod/_definst_/mp4:NTR36271d/permanent/playback/2/dlink-20160908205503.mp4/playlist.m3u8'
[PROGRAM]
[STREAM]
display_aspect_ratio=0:1
r_frame_rate=30/1
avg_frame_rate=0/0
[/STREAM]
[/PROGRAM]
[STREAM]
display_aspect_ratio=0:1
r_frame_rate=30/1
avg_frame_rate=0/0
[/STREAM] |
I have the same problem, but for my streams the story is a little bit different. My Setup:
|
If it did not happen before, it's probably one of Chrome's bad MP4 decoder phases - wait for the next update ;-) |
This stream's problems are not limited to Chrome. I see garbled video in Firefox 51, Chrome 53, and Safari on OS X 10.11.6. |
@cpeterso - indeed, I was staring at the bug title and forgot. So it may worth looking into the stream. Strictly speaking the missing value for average frame rate could signal variable frame rate. |
the way NAL units are spread across PES packet is weird: the stream is playing with flashls and natively so I will dig further to understand what is going on. [log] > AUD SPS PPS IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR IDR |
Thanks guys for your feedback. Much appreciated. |
FYI the mp4 was generated through Wowza using the "Live Stream Recording" functionality. Once the live is over the recorded mp4 is there for on-demand viewing. |
previously samples were splitted both on new PES and AUD NAL unit related to #676
the issue should be fixed, please check here, I did the fix in a dedicated branch as it still need a bit of cleanup and additional testing |
I can confirm that the issue is not happening anymore where we did notice it with this patch. |
I can also confirm that in my case green artifacts is gone with this fix. |
previously samples were splitted both on new PES and AUD NAL unit related to #676
should be fixed on master now |
Yes the issue is fixed on master as well. |
released in v0.6.2-7 |
Environment
Steps to reproduce
Go into sample page for hls.js http://dailymotion.github.io/hls.js/demo/ with latest Chrome on latest Mac OS X. Load the above HLS feed.
![green](https://cloud.githubusercontent.com/assets/18260893/18379826/c52b4c7c-7674-11e6-88e5-11f3867e568c.png)
See the green artifacts in the upper part of the video.
Expected behavior
It should not be green. VLC plays this HLS feed without issue. JW player also does play this HLS stream without issue on the same browser/OS (http://demo.jwplayer.com/stream-tester/)
Actual behavior
Green artifacts. I undertsand those are likely decoding artifacts provided by the OS or the browser. Actually this stream plays fine in Windows 10 latest Chrome or Canary. But I wonder why other player can play it without issue while hls.js fails. Is there a setting that can help fix this issue? Is there something to investiagte further?
Console output
The text was updated successfully, but these errors were encountered: