Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative audio with main with audio not working #763

Closed
4 tasks done
sergiojm opened this issue Oct 23, 2016 · 3 comments
Closed
4 tasks done

Alternative audio with main with audio not working #763

sergiojm opened this issue Oct 23, 2016 · 3 comments

Comments

@sergiojm
Copy link
Contributor

Environment
  • The stream has correct Access-Control-Allow-Origin headers (CORS)
  • There are no network errors such as 404s in the browser console when trying to play the stream
  • The issue observed is not already reported by searching on Github under https://github.com/dailymotion/hls.js/issues
  • The issue occurs in the latest reference client on http://dailymotion.github.io/hls.js/demo and not just on my page
  • Hls.js version: 0.6.6
  • Browser name/version: all
  • OS name/version: all
  1. Manifest with original audio(from the video itself) with alternative audio tracks.
  2. Change to a alternative track
  3. seek to a non buffered position

Now you can hear for a glip the alternative audio track and then falls back to original audio.

Impacts VOD and live with alternative audio and main with audio. Not happen when audio is only available on alternative audio tracks.

@sergiojm sergiojm mentioned this issue Oct 23, 2016
4 tasks
@sergiojm
Copy link
Contributor Author

this.audioTrackType on onFragParsingData is undefined

@sergiojm
Copy link
Contributor Author

sergiojm commented Oct 23, 2016

My first commit here probably didn't linked correctly the pull request :)

pull request: https://github.com/dailymotion/hls.js/pull/765

@mangui
Copy link
Member

mangui commented Oct 24, 2016

indeed, regression from sergiojm@3f55cb6
your fix is correct, merging

@mangui mangui closed this as completed Oct 24, 2016
@mangui mangui changed the title Alternative audio with main with audio Alternative audio with main with audio not working Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants