Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.67 does not dispatch ID3 tags (Hls.Events.FRAG_PARSING_METADATA) #794

Closed
1 of 2 tasks
lemonwhale opened this issue Nov 3, 2016 · 18 comments
Closed
1 of 2 tasks
Labels

Comments

@lemonwhale
Copy link

Environment
Steps to reproduce
  1. Please provide clear steps to reproduce your problem
    play the url above in a hls.js player and listen for the FRAG_PARSING_METADATA event.
  2. Whenever possible, share a demo/example page which reproduces the problem you are having with the least amount of code possible.
  3. If the bug is intermittent, give a rough frequency if possible. Consistent bug in v 0.67
Expected behavior

What you expected to happen
Hls.Events.FRAG_PARSING_METADATA callback when a ID3 tag is reached in the stream. This works in earlier versions.

Actual behavior

What actually happened

Console output
Paste the contents of the browser console here.
For media errors reported on Chrome browser, please also paste the output of chrome://media-internals 
@mangui
Copy link
Member

mangui commented Nov 3, 2016

Hi @lemonwhale, in order to speed up the investigation could you let us know the latest hls.js version with which you got it working ?

@lemonwhale
Copy link
Author

Thank you for the fast response, I believe that it was: HLS.js 0.6.2-6

Not totally sure but most likely.

Svante

2016-11-03 8:57 GMT+01:00 Guillaume du Pontavice notifications@github.com:

Hi @lemonwhale https://github.com/lemonwhale, in order to speed up the
investigation could you let us know the latest hls.js version with which
you got it working ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-258081366,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQM60ModdSGmQsABcuh8KpOQFScc7ks5q6ZPhgaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@mangui
Copy link
Member

mangui commented Nov 3, 2016

your stream is not working

@lemonwhale
Copy link
Author

Alright, that might be a problem, since I believe that it stops working (a
session) after a little while.

New attempt:

http://csm-e-eur4-2n6peplfblge.cds1.yospace.com/csm/live/119767587.m3u8;jsessionid=AE4CFB5CCD7A029231542D2250775A28.csm-e-eur4-2n6peplfblge.cds1.yospace.com?yo.ac=true&t=long_form,TV4Play,live,Test%20livereklam%2013,BI7329,BI0288,BI4759,BI0102,BI4616,BI0448,BI9363,BI7862,BI9867,BI6158,BI2076,BI4321,BI0485,BI6591,BI1265,BI2788,BI0265,BI1659,BI6058,BI9355,BI8465,BI7407,BI4334,BI9791,BI8022,BI8886,BI7583,BI5218,BI5152,BI3274&s=TV4Play%2Flive&dcid=desktop_html5

/Svante

2016-11-03 10:21 GMT+01:00 Guillaume du Pontavice notifications@github.com
:

your stream is not working


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-258094277,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQLGnx4OuAyqTaiQiPK6aGf0y2f7Wks5q6aeBgaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@mangui
Copy link
Member

mangui commented Nov 3, 2016

I don't get any parsed ID3 frames with older versions as well
there is indeed a PID with an unknown type referenced in the PMT:
unkown stream type:134 but this is not matching with the one expected for metadata (should be 21=0x15)

@lemonwhale
Copy link
Author

We get ID3 tags with the old version, but they only occur when there is
advertisments in the adstitched stream, which is roughly every 20 minutes.
I understand if you don't have time to wait for that.

/Svante

2016-11-03 11:02 GMT+01:00 Guillaume du Pontavice notifications@github.com
:

I don't get any parsed ID3 frames with older versions as well
there is indeed a PID with an unknown type referenced in the PMT:
unkown stream type:134 but this is not matching with the one expected for
metadata (should be 21=0x15)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-258102502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQPR4VESQItZosLVJDF9zdgSafqe4ks5q6bE-gaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@lemonwhale
Copy link
Author

Additional info:

yospace creates adstitched streams togethern with ooyala adserver.

2016-11-04 10:55 GMT+01:00 Svante Holmdahl svante.holmdahl@lemonwhale.com:

We get ID3 tags with the old version, but they only occur when there is
advertisments in the adstitched stream, which is roughly every 20 minutes.
I understand if you don't have time to wait for that.

/Svante

2016-11-03 11:02 GMT+01:00 Guillaume du Pontavice <
notifications@github.com>:

I don't get any parsed ID3 frames with older versions as well
there is indeed a PID with an unknown type referenced in the PMT:
unkown stream type:134 but this is not matching with the one expected
for metadata (should be 21=0x15)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-258102502,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQPR4VESQItZosLVJDF9zdgSafqe4ks5q6bE-gaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@mangui
Copy link
Member

mangui commented Nov 4, 2016

if you could extract a snapshot of your live playlist highlighting the issue, then I could check what is going on.

@lemonwhale
Copy link
Author

I am sorry, I might not have given you the best url to look at. here is a
better one.

http://csm-e.cds1.yospace.com/csm/live/119767587.m3u8

My appologies. I will try to send you a snapshot

/Svante

2016-11-04 11:00 GMT+01:00 Guillaume du Pontavice notifications@github.com
:

if you could extract a snapshot of your live playlist highlighting the
issue, then I could check what is going on.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-258387896,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQHkd8R6ZHXGbWAQ6sIghRNNPJ-2Sks5q6wI7gaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@lemonwhale
Copy link
Author

The ID3 tags are located in the segments, so I think its difficult for me
to send snapshots of them. But if you play the stream I sent you in the
most previous mail, the ID3 tags do exist there.

Svante

2016-11-04 11:27 GMT+01:00 Svante Holmdahl svante.holmdahl@lemonwhale.com:

I am sorry, I might not have given you the best url to look at. here is a
better one.

http://csm-e.cds1.yospace.com/csm/live/119767587.m3u8

My appologies. I will try to send you a snapshot

/Svante

2016-11-04 11:00 GMT+01:00 Guillaume du Pontavice <
notifications@github.com>:

if you could extract a snapshot of your live playlist highlighting the
issue, then I could check what is going on.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-258387896,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQHkd8R6ZHXGbWAQ6sIghRNNPJ-2Sks5q6wI7gaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@mangui
Copy link
Member

mangui commented Nov 4, 2016

in case of regression around v0.6.2-7 I would suspect this commit: dailymotion@4123ddd , but it is really difficult to assess as I seldom get ID3 tags in the stream (actually I saw ID3 PID once in the logs, but after instrumenting the code they were gone and I didn't observe any in the last 15mn)

@lemonwhale
Copy link
Author

Sorry for the late response. Thank you for checking, I believe that you
might be right with that commit. Will you have the possibility to continue
to look at this? The url I provided has ID3 tags enabled.

/Svante

2016-11-04 14:05 GMT+01:00 Guillaume du Pontavice notifications@github.com
:

in case of regression around v0.6.2-7 I would suspect this commit: 4123ddd
dailymotion@4123ddd
, but it is really difficult to assess as I seldom get ID3 tags in the
stream (actually I saw ID3 PID once in the logs, but after instrumenting
the code they were gone and I didn't observe any in the last 15mn)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-258425548,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQE1-XUUUwF21aN1PqhXqbLQRYY8Uks5q6y2FgaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@mangui
Copy link
Member

mangui commented Nov 9, 2016

Hi @lemonwhale it is pretty hard to investigate as I rarely get ID3 data with this stream. what would be great is to get a snapshot of this live stream with ID3 data.

@lemonwhale
Copy link
Author

Thanks for the quick response.

Could you please describe what you mean with at snapshot? Sorry I don't
understand that.

2016-11-09 15:24 GMT+01:00 Guillaume du Pontavice notifications@github.com
:

Hi @lemonwhale https://github.com/lemonwhale it is pretty hard to
investigate as I rarely get ID3 data with this stream. what would be great
is to get a snapshot of this live stream with ID3 data.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-259426119,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQCCtzz3YqCW5D98IyFBJQcMOOB92ks5q8de7gaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@mangui
Copy link
Member

mangui commented Nov 9, 2016

I would need an extract of your live playlist (a couple of fragments) containing ID3 tags

@lemonwhale
Copy link
Author

I could't do that, however, I can trigger ID3 tags whenever it suits you.
What would be a suitable time (and timezone) for you to check for the event?

/Svante

2016-11-09 15:27 GMT+01:00 Guillaume du Pontavice notifications@github.com
:

I would need an extract of your live playlist (a couple of fragments)
containing ID3 tags


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dailymotion/hls.js/issues/794#issuecomment-259426766,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACgvQLSq8lRb6hURGB-Y4dJrj-tv1KStks5q8dhkgaJpZM4KoEg3
.

Svante Holmdahl
Lemonwhale
Malmskillnadsgatan 32
SE-111 51 Stockholm, Sweden
Mob: +46 707 599021

@mangui
Copy link
Member

mangui commented Nov 9, 2016

plz join https://hlsjs.herokuapp.com/ so that we could sync

mangui added a commit that referenced this issue Nov 9, 2016
mangui added a commit that referenced this issue Nov 9, 2016
related to #794
@mangui
Copy link
Member

mangui commented Nov 9, 2016

as discussed on Slack, should be fixed, plz recheck against hls.js/master, latest demo page

@mangui mangui added Bug and removed Need info labels Nov 9, 2016
@mangui mangui closed this as completed Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants