-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 0.67 does not dispatch ID3 tags (Hls.Events.FRAG_PARSING_METADATA) #794
Comments
Hi @lemonwhale, in order to speed up the investigation could you let us know the latest hls.js version with which you got it working ? |
Thank you for the fast response, I believe that it was: HLS.js 0.6.2-6 Not totally sure but most likely. Svante 2016-11-03 8:57 GMT+01:00 Guillaume du Pontavice notifications@github.com:
Svante Holmdahl |
your stream is not working |
Alright, that might be a problem, since I believe that it stops working (a New attempt: /Svante 2016-11-03 10:21 GMT+01:00 Guillaume du Pontavice notifications@github.com
Svante Holmdahl |
I don't get any parsed ID3 frames with older versions as well |
We get ID3 tags with the old version, but they only occur when there is /Svante 2016-11-03 11:02 GMT+01:00 Guillaume du Pontavice notifications@github.com
Svante Holmdahl |
Additional info: yospace creates adstitched streams togethern with ooyala adserver. 2016-11-04 10:55 GMT+01:00 Svante Holmdahl svante.holmdahl@lemonwhale.com:
Svante Holmdahl |
if you could extract a snapshot of your live playlist highlighting the issue, then I could check what is going on. |
I am sorry, I might not have given you the best url to look at. here is a http://csm-e.cds1.yospace.com/csm/live/119767587.m3u8 My appologies. I will try to send you a snapshot /Svante 2016-11-04 11:00 GMT+01:00 Guillaume du Pontavice notifications@github.com
Svante Holmdahl |
The ID3 tags are located in the segments, so I think its difficult for me Svante 2016-11-04 11:27 GMT+01:00 Svante Holmdahl svante.holmdahl@lemonwhale.com:
Svante Holmdahl |
in case of regression around v0.6.2-7 I would suspect this commit: dailymotion@4123ddd , but it is really difficult to assess as I seldom get ID3 tags in the stream (actually I saw ID3 PID once in the logs, but after instrumenting the code they were gone and I didn't observe any in the last 15mn) |
Sorry for the late response. Thank you for checking, I believe that you /Svante 2016-11-04 14:05 GMT+01:00 Guillaume du Pontavice notifications@github.com
Svante Holmdahl |
Hi @lemonwhale it is pretty hard to investigate as I rarely get ID3 data with this stream. what would be great is to get a snapshot of this live stream with ID3 data. |
Thanks for the quick response. Could you please describe what you mean with at snapshot? Sorry I don't 2016-11-09 15:24 GMT+01:00 Guillaume du Pontavice notifications@github.com
Svante Holmdahl |
I would need an extract of your live playlist (a couple of fragments) containing ID3 tags |
I could't do that, however, I can trigger ID3 tags whenever it suits you. /Svante 2016-11-09 15:27 GMT+01:00 Guillaume du Pontavice notifications@github.com
Svante Holmdahl |
plz join https://hlsjs.herokuapp.com/ so that we could sync |
as discussed on Slack, should be fixed, plz recheck against hls.js/master, latest demo page |
Environment
Steps to reproduce
play the url above in a hls.js player and listen for the FRAG_PARSING_METADATA event.
Expected behavior
What you expected to happen
Hls.Events.FRAG_PARSING_METADATA callback when a ID3 tag is reached in the stream. This works in earlier versions.
Actual behavior
What actually happened
Console output
The text was updated successfully, but these errors were encountered: