New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and use generic playlist attribute list parser #107
Conversation
also exposes any stream info attribute for external processing
I would be keen to merge this, but it would be good to add some unit tests to cover the new parsing code, so that in case it breaks anything or if we modify it later on, we can easily spot any regression. |
related with https://github.com/dailymotion/hls.js/pull/106 |
Updated with tests, which are failing due to old node version on travis. |
Anything you are missing here? |
@kanongil |
@@ -38,6 +38,8 @@ | |||
"webworkify": "^1.0.2" | |||
}, | |||
"devDependencies": { | |||
"arraybuffer-equal": "^1.0.4", | |||
"babel": "^5.8.34", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kanongil i am not clear about this new dependency to babel ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mocha
does not understand es6 code and needs a compiler, which I register using --compilers js:babel/register
. As such it needs to be declared a dev dependency as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine, I will give it a hand soon
merged, I also added a couple of unit tests to cover manifest parsing code ... |
Prevent audio track from starting at EOS
This fixes order dependent parsing of
EXT-X-STREAM-INF
attributes.This also exposes any stream info attribute for external processing.
Tested to work on a normal and encrypted stream in Chrome.