Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hls-mp4: fix uint32's parsing #1165

Merged
merged 1 commit into from May 23, 2017
Merged

hls-mp4: fix uint32's parsing #1165

merged 1 commit into from May 23, 2017

Conversation

kanongil
Copy link
Contributor

Description of the Changes

The uint32 parsing logic actually produces int32 values, due to use of bitwise operators. This means that negative values can be parsed, which can cause the processing to fail.

I discovered this, when debugging a stream that suddenly stopped working, while spouting negative timestamp values into the debug log. Specifically, it was the parsing of the lower bits of a version==1 tfdt box. I fixed the other instances as well for good measure.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • no commits have been done in dist folder (we will take care of updating it)
  • new unit / functional tests have been added (whenever applicable)
  • Travis tests are passing (or test results are not worse than on master branch :))
  • API or design changes are documented in API.md

@mangui
Copy link
Member

mangui commented May 23, 2017

thanks @kanongil
LGTM, merging

@mangui mangui merged commit 9e50bb5 into video-dev:master May 23, 2017
@mangui mangui changed the title Parse uint32's correctly hls-mp4: Parse uint32's correctly May 29, 2017
@mangui mangui changed the title hls-mp4: Parse uint32's correctly hls-mp4: fix uint32's parsing May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants