Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
The uint32 parsing logic actually produces int32 values, due to use of bitwise operators. This means that negative values can be parsed, which can cause the processing to fail.
I discovered this, when debugging a stream that suddenly stopped working, while spouting negative timestamp values into the debug log. Specifically, it was the parsing of the lower bits of a
version==1
tfdt
box. I fixed the other instances as well for good measure.CheckLists