Prevent tick() handler from being entered while already processing #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
or we should never call |
|
Hi, |
mangui
added a commit
that referenced
this pull request
Dec 22, 2015
Prevent tick() handler from being entered while already processing
tchakabam
reviewed
Nov 28, 2017
| if (this.ticks === 1) { | ||
| this.doTick(); | ||
| if (this.ticks > 1) { | ||
| setTimeout(this.tick, 1); |
There was a problem hiding this comment.
@kanongil how can this line of code ever be reached? (given that we never call doTick() directly, but only tick(), and that this is the only place where we increment the counter)
There was a problem hiding this comment.
haha i got it finally. this somehow was a bit tricky to get to me :D
johnBartos
pushed a commit
that referenced
this pull request
Jun 27, 2018
…hes the spec (1-15) and the range of position values fall within the 80% width that the spec suggests. (#126) JW8-205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loose event coupling means that
tick()can easily be called while processing atick(). This can lead to all sorts of weird behavior.I am aware of at least one case where this happens: When loading a key which has already been loaded, the
onKeyLoadedcallback is called synchronously while a tick is processing, triggering anothertick().