Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AAC streams without ID3 to play #1364

Merged

Conversation

johnBartos
Copy link
Collaborator

@johnBartos johnBartos commented Sep 21, 2017

Description of the Changes

  • Allow AAC demuxing without a timestamp or ID3 data
  • Scan entire fragment for ADTS syncword if no ID3 is found
  • For AAC streams without ID3, calculate PTS using a default value + time offset
  • Probe for TS before AAC because TS demuxing is more accurate (prevents TS streams with AAC audio from being demuxed with the AAC demuxer)

AAC streams do not need to have ID3 data if they don't need to synchronize with a video track, i.e. in audio-only streams.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • no commits have been done in dist folder (we will take care of updating it)
  • new unit / functional tests have been added (whenever applicable)
  • Travis tests are passing (or test results are not worse than on master branch :))
  • API or design changes are documented in API.md

@mangui
Copy link
Member

mangui commented Sep 22, 2017

LGTM

@mangui mangui merged commit 67c6959 into video-dev:master Sep 22, 2017
@robwalch robwalch deleted the upstream/feature/support-aac-without-id3 branch January 27, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants