New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue 1331 error on dai discont #1409
Fix/issue 1331 error on dai discont #1409
Conversation
… each type of track. Before we were following the TS PIDs. These can change on discontinuities. Switching track IDs, following PID, doesn't have any advantage for (we only have one track of each anyway). It is allowed by ISOFF when we only have one track of a type. It turns out that Safari has issues and was dropping all frames when it was set up to demux from a specific track ID at the start, and then the video track having a different one (Hls.js ISSUE-1331). We add here constant track IDs per remuxed track type. We also make sure that we keep carrying the PID in our track state, and also handle missing PIDs, but the PID never drives the track ID at any point. We also add some more spec/docs and centralize the creation of TS demuxer internal track model.
Confirmed working in our environment. 👍 Thanks! |
thanks @tchakabam ! |
oh, no idea how dist.zip appeared there :) |
Will add test stream. Need to figure out however why the CI job is failing at:
I re-ran the job before to see if it is something occuring rarely, but it happened again, so consistent. Trying again restarting now. Any ideas? Would it be related to our change? Isn't it very weird that I wonder how the build is not completely reproducible. Are the browser test-platforms changing, could we have switched versions between these two jobs? |
-> Will try to reproduce that locally later! -> Probably a bug related to our change but error happening only at ~30% probability ? EDIT: Build job has normalized now after 4th re-run attempt. |
Description of the Changes
Fixes #1331
Before we were following the TS PIDs. These can change on discontinuities. Switching track IDs, following PID, doesn't have any advantage for (we only have one track of each anyway). It is allowed by ISOFF when we only have one track of a type. It turns out that Safari has issues and was dropping all frames when it was set up to demux from a specific track ID at the start, and then the video track having a different one (Hls.js ISSUE-1331).
We add here constant track IDs per remuxed track type. We also make sure that we keep carrying the PID in our track state, and also handle missing PIDs, but the PID never drives the track ID at any point. We also add some more spec/docs and centralize the creation of TS demuxer internal track model.
CheckLists