New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoder unit tests added #1507
Decoder unit tests added #1507
Conversation
Lastest public changes
Update to latest
Merge latest changes
Getting latest changes from main branch
…ods are not changed lightly
thanks @capagrisdesu, could u rebase against latest master as unit tests are not passing on Travis ? |
You are welcome @mangui but I can see that the error in Travis is |
Update to latest 22/1/18
these issues should have been fixed on master |
@mangui If you run master npm run test, you will get errors. I am concerned that this happens fairly frequently. Maybe people are not checking their PRs before submitting them.
src\remux\mp4-remuxer.js: line 209, col 30, Expected '===' and instead saw '=='. |
Latest merge 1/26/18
Hi @mangui unit test passing, could you merge? |
thanks for this PR, LGTM merging |
Description of the Changes
As I have been concerned about how to improve coverage in hls.js I decided to experiment doing some unit tests using sinon to mock objects. Hls.js modules are fairly complex and testing one function usually requires testing hundreds of lines which is not ideal for the purpose of unit tests so this is showcase demo of how to test small pieces of code. I decided to use Demuxer as it is a fundamental piece of the library that has not yet been unit tested. This is useful to the project and others may use sinon in similar fashion in order to do more unit tests and increase the current low coverage of the library.
CheckLists