Add a regex to check different mp4 suffix.

[oldmtn]

This PR will add regex to check mp4 suffix.

Why is this Pull Request needed?

The original code need a an regex to handle other type of suffix.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixed old "FIXME".

Checklist

• changes have been done against master branch, and PR does not conflict
• no commits have been done in dist folder (we will take care of updating it)
• new unit / functional tests have been added (whenever applicable)
• API or design changes are documented in API.md

[tjenkinson]

Please can you extract the regex outside the function to a constant, maybe at the top of the file? Otherwise it has to be evaluated every time this runs.

Also I think you need to escape the '.' s otherwise they mean any character

 /\.(mp4|m4s|m4v|m4a)$/i

Should do it and mean you don't need to convert to lower case

[tjenkinson]

Also I think this could just be a standard function. It doesn't need to be exported given nothing else is using it. If minifies better that way

[oldmtn]

you don't need to convert to lower case

Some file suffix could be .MP4 or .M4S, so why don't need to convert to lower case.

[tjenkinson]

@oldmtn the /i flag makes the regex case insensitive. Also creating RegExp isn't needed here.

const MP4_SUFFIX = /\.(mp4|m4s|m4v|m4a)$/i;

function checkMP4Suffix(str) {
  return MP4_SUFFIX.test(str)
}

should be fine, and I'd then remove the function and just inline that

if (level.fragments.every((frag) => MP4_SUFFIX.test(frag.relurl))) {

[tjenkinson]

Great

[tjenkinson]

thanks @oldmtn