Fix memory leak

[bwallberg]

This PR will...

Fixed AudioStreamController & StreamController not being cleaned up

• onHandlerDestroying() is overriden by said controllers but doesn't call
  super.onHandlerDestroying() which cases the tick interval to never stop

Why is this Pull Request needed?

Because hls.js is leaking memory after destroy()

Are there any points in the code the reviewer needs to double check?

no

Resolves issues:

Checklist

• changes have been done against master branch, and PR does not conflict
• no commits have been done in dist folder (we will take care of updating it)
• new unit / functional tests have been added (whenever applicable)
• API or design changes are documented in API.md

[tchakabam]

Great. Thanks so much. This was a stupid bug indeed :)

I would actually like to make using TaskLoop consistent, and this is a good step in the direction, as it is a querk we needed to figure out when overloading those methods. We will have to be careful with this.

Generally, in our roadmap we have an item saying we would like to run one single scheduler for everything actually, centrally manage all the intervals and timeouts, ideally only have on interval running that processes the tasks (which is the idea of task-loop actually, but right now it's more of a thing trying to reduce code redundancy across all the components using some sort of event-loop scheduling via timeout/interval). A next step could be actually having a singleton interval that consumer dispatch tasks on instead of every component having it's own interval loop.

This is a good fix anyway! Thanks!

It would be nice if we find a trick to have components extend from TaskLoop but not have to care about de-initializing it like this. For example we could actually have them not overload these methods but rather have TaskLoop have it's own hooks that are supposed to be overloaded by subclass, and which are being called by the TaskLoop destroy-listeners.

[tchakabam]

👍 lgtm

[johnBartos]

Actually, does this matter? onHandlerDestroyed is not implemented except in the leaf class (i.e. stream-controller).

[johnBartos]

Maybe I'm missing something ^

[johnBartos]

Nevermind, local branch is out of date