Refactoring some things, part 1: EventHandler #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling across all components
…elf it local scope of handlers anymore
tchakabam
changed the title
…vent-handler Conflicts: src/controller/level-controller.js src/controller/mse-media-controller.js
|
reviewed and tested working fine, merging. |
mangui
added a commit
that referenced
this pull request
Jan 18, 2016
Refactoring some things, part 1: EventHandler
mangui
referenced
this pull request
Jan 18, 2016
johnBartos
pushed a commit
that referenced
this pull request
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces EventHandler in every place possible, adds unit test for Events enum consistency with generics convention assumed by EventHandler.
@mangui