Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix api link on demo page #1943

Merged
merged 2 commits into from
Oct 4, 2018
Merged

fix api link on demo page #1943

merged 2 commits into from
Oct 4, 2018

Conversation

tjenkinson
Copy link
Member

Follow on from #1940

The change there wouldn't work when the demo was accessed on /latest, /stable, or /<commit hash>

Also /demo only existed by mistake. I removed it 37246e6

If people are actually loading the demo on /demo we will need to add a redirect

Copy link
Collaborator

@tchakabam tchakabam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better 👍

@tjenkinson tjenkinson merged commit 0aa5a71 into master Oct 4, 2018
@tjenkinson tjenkinson deleted the fix-api-link-on-demo branch October 4, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants