Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure netlify for PR's #2101

Merged
merged 6 commits into from
Jan 28, 2019
Merged

configure netlify for PR's #2101

merged 6 commits into from
Jan 28, 2019

Conversation

tjenkinson
Copy link
Member

This PR will...

add the netlify config for PR's to the repo. I also created a netlify account with the hlsjs ci github user.

Why is this Pull Request needed?

It means that PR preview deploys to netlify also use the same script as canary and production builds, and are also using the same netlify account

Tom Jenkinson added 3 commits January 26, 2019 17:57
this follows the same process that runs for canary releases
because on netlify it clones the whole thing
@tjenkinson tjenkinson force-pushed the netlify branch 4 times, most recently from d567e25 to aede8f3 Compare January 26, 2019 22:52
@tjenkinson tjenkinson force-pushed the netlify branch 4 times, most recently from 35788d3 to 4a62bbf Compare January 27, 2019 10:04
@tjenkinson tjenkinson self-assigned this Jan 27, 2019
Copy link
Member

@michaelcunningham19 michaelcunningham19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tjenkinson tjenkinson merged commit dcb3db6 into master Jan 28, 2019
@tjenkinson tjenkinson deleted the netlify branch January 28, 2019 18:00
@johnBartos johnBartos added the CI label Aug 13, 2019
@johnBartos johnBartos modified the milestone: 0.13.0 Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants