Apply TypeScript to Fragment & LevelKey #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tjenkinson another one up for ya to review :) |
Co-Authored-By: itsjamie <1956521+itsjamie@users.noreply.github.com>
parseByteRange -> setByteRange - removed it returning the parsed value since its usage was like a setter.
tjenkinson
reviewed
Jan 29, 2019
itsjamie
commented
Jan 30, 2019
|
Link #2070 |
tjenkinson
reviewed
Jan 31, 2019
|
Just waiting for travis to go green and then I think this is good to go 🎉 |
tjenkinson
approved these changes
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Update the Fragment and LevelKey value classes to TypeScript.
Why is this Pull Request needed?
Part of the effort to convert the internals of hls.js to Typescript.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist