-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SEI with resolution payloadType 5 based on H264 specification (Us… #2126
Conversation
…er data unregistered SEI message)
Hey @bruce1i ! Would you be able to provide either a test stream containing custom data, or some code snippets of how you're inserting data into a stream? As an aside, I'd like to hear from other collaborators on their thoughts of incorporating additions like this to the core library. Thinking about bundle size and modularity, it may be beneficial to explore emitting helpers alongside with the main code bundle |
Hey @michaelcunningham19 ! 1. Test stream containing custom data. 2. Some code snippets of how you're inserting data into a stream. My purpose1. Why I commit this PR. 2. The bundle size. |
Hi @michaelcunningham19 @johnBartos , Is there any new progress or conclusion? |
Any further progress for this PR? I encountered same issue with hls.js as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruce1i @iamzhouyi Sorry for the delay - LGTM
This PR will parse SEI with resolution payloadType 5 based on H264 specification. Now you can write custom data to H264 and get it from 'Hls.Events.FRAG_PARSING_USERDATA' event.
Why is this Pull Request needed?
A: User can get custom data from SEI. It's especially useful in live streaming.
Are there any points in the code the reviewer needs to double check?
A: No.
Resolves issues:
A: Just add a SEI parsing rule.
Checklist