Init segment should not be treated as start segment #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBartos
approved these changes
Mar 27, 2019
|
Good find, thanks! |
3 tasks
This was referenced Jun 6, 2021
1 task
This was referenced Aug 13, 2022
1 task
This was referenced Nov 4, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Init segment shouldn't be considered as a requested start fragment.
Why is this Pull Request needed?
We are preparing to switch some streams from HLS TS to HLS MP4 (to use with Widevine/Playready). While doing this I noticed that hls.js didn't start LIVE streams with first video segment (0.m4s) but instead requested the last video segment in playlist first (2.m4s). After some debugging I found out that due to init segment being requested first, the
this.startFragRequested = true;flag has been set. This caused the_ensureFragmentAtLivePointtrying to find the correct fragment without having any previous fragment as reference. By not setting thestartFragRequestedfor initSegment this issue is fixed.Are there any points in the code the reviewer needs to double check?
Does it break anything?
Resolves issues:
Wrong start video fragment requested in LIVE MP4 HLS streams.
Checklist