Demo timeline chart tab #2546
Merged
Demo timeline chart tab #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
feature/demo-timeline
branch
from
e02b4b7
to
80cb130
Compare
michaelcunningham19
requested review from
johnBartos and
michaelcunningham19
and removed request for
johnBartos
michaelcunningham19
approved these changes
Mar 11, 2020
Korilakkuma
reviewed
Mar 11, 2020
| if (!video.readyState || video.ended) { | ||
| return 'rgba(0, 0, 0, 0.9)'; | ||
| } | ||
| if (video.seeking || video.readyState < 3) { |
There was a problem hiding this comment.
I think better to use HTMLVideoElement.HAVE_FUTURE_DATA instead of magic number.
There was a problem hiding this comment.
I avoid references to HTMLMediaElement and it's properties in case they are tampered with or missing in legacy browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Add a tab to the demo page that renders a timeline showing playlist fragments and texttrack cues for loaded levels, and tracks.
Why is this Pull Request needed?
Visualize streaming behavior, or how hls.js aligns and buffers segments and metadata.
Try it out
Open the preview build https://deploy-preview-2546--hls-js-pr.netlify.com/demo/ and click the "Timeline" button under the player:
Checklist