Reduce log output for unknown elementary stream types #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Improve logging for streams with with unknown or unsupported elementary stream types.
Why is this Pull Request needed?
An unknown elementary stream type can result in hundreds of the same log statement every segment. These changes reduce that to one log statement per PMT type, per segment.
I observed severe browser performance degradation with dev tools open in Firefox when verifying #2684. By reducing the number of log statements, the dev tools can be used without stalling the browser / page.
Related issues:
#2684
Checklist