Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include old WebKit based browsers in positive DTS gate #3224

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

robwalch
Copy link
Collaborator

This PR will...

Prevent us from using negative DTS values in AVC moof atoms in old webkit browsers.

Why is this Pull Request needed?

Fixes a decode errors in 2017 Tizen Smart TVs in streams where we try to minimizing video start gaps by aligning video and audio as close to 0 as possible without changing initial CTS.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #3211

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 0.15.0 milestone Nov 12, 2020
b-Rogers
b-Rogers previously approved these changes Nov 12, 2020
Copy link

@b-Rogers b-Rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Tizen 2017. Can confirm this fixes issue #3211.

@robwalch robwalch merged commit 05d185e into master Nov 16, 2020
@robwalch robwalch deleted the bugfix/use-positive-dts-with-old-webkit branch November 16, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback failure on Samsung 2017 Tizen TV
3 participants