Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply default flags and duration from trex box #3233

Merged
merged 1 commit into from Nov 17, 2020
Merged

Apply default flags and duration from trex box #3233

merged 1 commit into from Nov 17, 2020

Conversation

kanongil
Copy link
Contributor

@kanongil kanongil commented Nov 17, 2020

This PR will...

Fix playback of streams using fMP4 where the sample duration is stored in the trex box.

Why is this Pull Request needed?

To successfully play more streams.

Are there any points in the code the reviewer needs to double check?

No.

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch
Copy link
Collaborator

Hi @kanongil,

Do you have a sample stream I can verify this fix with?

@kanongil
Copy link
Contributor Author

Yes, I have a public stream here: https://stream.sob.m-dn.net/live/sb1/index.m3u8

This specific stream is not LL-HLS enabled yet, and appears ok, but will report errors in the console (on v1.0.0-alpha.2).

@robwalch robwalch merged commit d657809 into video-dev:feature/v1.0.0 Nov 17, 2020
@robwalch
Copy link
Collaborator

robwalch commented Nov 17, 2020

Thanks @kanongil! Great fix and much appreciated.

I wonder if there are other circumstances where we wouldn't be able to determine the duration of fmp4. The console.asserts are helpful for catching these instances, but I haven't seen a wide variety of fmp4 streams, certainly not one like this.

d41f681 replaces the asserts with warnings, and falls back to playlist duration to avoid serious playback issues caused by mangled timelines that result from mp4 duration not being parsed.

robwalch pushed a commit that referenced this pull request Nov 23, 2020
…tion could not be parsed (zero or less) or seeking in VOD (#3110)

Follow up from #3233 for situations where fmp4 duration is still not being parsed correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants