Improve CEA-608 column to VTT position #3270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Calculate cue position for CEA-608 caption cues according to the PAC indent code table at https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608
Why is this Pull Request needed?
Improve rendering of 608 captions (multiline and left aligned).
Are there any points in the code the reviewer needs to double check?
Also a small optimization on whitespace check using RegEx.test rather than String.match.
Test streams:
https://playertest.longtailvideo.com/adaptive/captions/playlist.m3u8
https://playertest.longtailvideo.com/adaptive/cpcweb/cpcdemo.m3u8
Checklist