Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAMPLE-AES MPEG-TS streaming #3388

Merged
merged 2 commits into from Jan 21, 2021
Merged

Fix SAMPLE-AES MPEG-TS streaming #3388

merged 2 commits into from Jan 21, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jan 18, 2021

This PR will...

  • Fixes SAMPLE-AES streaming. Fix developed and tested against sample stream from https://demo.unified-streaming.com/keyrotation/
  • MPEG-TS Demuxer PES timestamp TypeScript cleanup; ID3 and MP3 PES with no PTS are dropped. AVC and AVC samples use previous PTS where available.

Why is this Pull Request needed?

Follow up from #3384
Fixes a regression introduced in 6836ef3
Adds more type safety to TSDemuxer

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.0.0 milestone Jan 18, 2021
@robwalch robwalch added this to Top priorities in Release Planning and Backlog via automation Jan 18, 2021
@robwalch robwalch moved this from Top priorities to v1.0.0-beta.4 in Release Planning and Backlog Jan 18, 2021
Follow up from #3384
Fixes a regression introduced in 6836ef3
ID3 and MP3 PES with no PTS are dropped. AVC and AVC samples use previous PTS where available/
@robwalch robwalch changed the title Fix SAMPLE-AES streaming Fix SAMPLE-AES MPEG-TS streaming Jan 19, 2021
@robwalch robwalch merged commit 18ec11a into master Jan 21, 2021
@robwalch robwalch deleted the bugfix/sample-aes branch January 21, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant