Fix 608 parsing continuity #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
moved this from Top priorities
to v1.0.0-beta.5
in Release Planning and Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix 608 parsing continuity regression introduced in #3423.
Why is this Pull Request needed?
The 608 parsers must be reset when fragment loading continuity ends. This was handled on FRAG_LOADED, but with v1, that event can and mostly does fire before FRAG_PARSING_USERDATA where 608 samples are received. I moved that logic to FRAG_PARSING_USERDATA but didn't realize that event fires twice for each fragment (once per transmuxer push and once again on flush). While I hope to address some of these details prior to v1.0.0 going GA, resetting on FRAG_LOADING gets the job done for now.
Checklist