Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Refused to get unsafe header "age" console error in Chrome #3686

Conversation

radiantmediaplayer
Copy link
Collaborator

This PR will...
Fix Refused to get unsafe header "age" console error in Chrome

Why is this Pull Request needed?
Resolves issues:
Resolves #3680

Copy link
Collaborator

@robwalch robwalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @radiantmediaplayer,

Thanks for this.

The build check is failing https://github.com/video-dev/hls.js/pull/3686/checks?check_run_id=2201339176

Please run these commands, and update your PR with any lint fixes per https://github.com/video-dev/hls.js/blob/master/CONTRIBUTING.md#creating-prs

npm run prettier && npm run sanity-check

Prettier will apply formatting rules, and the sanity-check runs linting, docs, build, and unit tests to make sure nothing was missed (it's a little more involved than the pre-commit hook).

@robwalch robwalch merged commit c45c4ec into video-dev:bugfix/ll-hls-cdn-tune-in-low-latency-mode Mar 26, 2021
@radiantmediaplayer
Copy link
Collaborator Author

Hi,
Thanks for getting this through. I actually ran npm run prettier && npm run sanity-check on my Windows machine before pushing but then I got an issue with GitHub Desktop that would not let me pass the pre-commit hook so I had to start anew from my macOS machine. Now this pass validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants