New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
608 #411
608 #411
Conversation
And implemented VTT cues in timeline-controller.js
sample duration is the DTS delta between consecutive samples (sorted by DTS) ensure that sample duration is constant accross a whole fragment, and also that composition time offset (pts-dts) is a multiple of sample duration, to please Safari and avoid intrafragment micro-holes related to #9
related to #9
related to #9
# Conflicts: # bower.json # dist/hls.js # dist/hls.js.map # dist/hls.min.js # package.json # src/remux/mp4-remuxer.js
# Conflicts: # dist/hls.js # dist/hls.js.map # dist/hls.min.js
great ! nice job @jlacivita |
@mangui done. I copied the /dist/ files from master and added design.md details. There's still some weird message about "file mode changed" on the dist files, but I don't know how to handle that. |
thanks @jlacivita I will try to squash everything next week, as the commit history is not clean |
Thanks, @mangui. Let me know what bad git habits I have. I can try and be cleaner next time. |
Hi @jlacivita everything has been merged into master now |
closing as merged |
@mangui I know it's checked into master, but any idea when you'll be releasing a tagged version of hls.js with this 608 interpreter? |
This has been tested by myself and other members of the community. It's far superior to the last version I worked on, and is ready for a merge into master.
I just merged the latest master into my tree, and did a quick sanity check on captions. all looks good.