-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing multiple user data unregistered SEI #4242
Closed
ioppermann
wants to merge
4
commits into
video-dev:master
from
datarhei:sei-multi-unregistered-userdata
Closed
Fix parsing multiple user data unregistered SEI #4242
ioppermann
wants to merge
4
commits into
video-dev:master
from
datarhei:sei-multi-unregistered-userdata
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
approved these changes
Dec 10, 2021
robwalch
added a commit
that referenced
this pull request
Dec 15, 2021
1 task
robwalch
added a commit
that referenced
this pull request
Dec 15, 2021
robwalch
added a commit
that referenced
this pull request
Dec 16, 2021
robwalch
added a commit
that referenced
this pull request
Dec 16, 2021
robwalch
added a commit
that referenced
this pull request
Jan 18, 2022
robwalch
added a commit
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
allow to parse more than the first user data unregistered SEI per video frame.
Why is this Pull Request needed?
It may be required by a player to have access to all user data unregistered SEI in order to control playback or to display additional information to the viewer.
Are there any points in the code the reviewer needs to double check?
I was wondering why only the first SEI is parsed (
endOfCaptions
set totrue
after encountering a supported payloadType) and couldn't find any documentation why this is the case. In the case of CC (payloadType 4) I could imagine that it might be problematic if there's more than one (looking atcontroller/timeline-controller.ts
). But for unregistered user data (payloadType 5) it shouldn't cause any issues.I also noticed that payloadtype 5 uses
userDataBytes
in the samples (instead ofbytes
as defined in theUserdataSample
interface). If it would usebytes
it would probably screw up theonFragParsingUserdata
method incontroller/timeline-controller.ts
. This PR doesn't mess with this.Resolves issues:
none
Checklist