Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing multiple user data unregistered SEI #4242

Closed

Conversation

ioppermann
Copy link

This PR will...

allow to parse more than the first user data unregistered SEI per video frame.

Why is this Pull Request needed?

It may be required by a player to have access to all user data unregistered SEI in order to control playback or to display additional information to the viewer.

Are there any points in the code the reviewer needs to double check?

I was wondering why only the first SEI is parsed (endOfCaptions set to true after encountering a supported payloadType) and couldn't find any documentation why this is the case. In the case of CC (payloadType 4) I could imagine that it might be problematic if there's more than one (looking at controller/timeline-controller.ts). But for unregistered user data (payloadType 5) it shouldn't cause any issues.

I also noticed that payloadtype 5 uses userDataBytes in the samples (instead of bytes as defined in the UserdataSample interface). If it would use bytes it would probably screw up the onFragParsingUserdata method in controller/timeline-controller.ts. This PR doesn't mess with this.

Resolves issues:

none

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch self-requested a review December 10, 2021 00:14
robwalch added a commit that referenced this pull request Dec 15, 2021
Resolves #2623 (Add CMAF CC support)
Resolves #4242 (Fix parsing multiple user data unregistered SEI)
Closes #4421 (Does hls.js support extracting SEI frame from videos?)
Fixes #4317 (Progressive mode is broken with fmp4 playback)
@robwalch robwalch mentioned this pull request Dec 15, 2021
1 task
@robwalch robwalch added this to the 1.2.0 milestone Dec 15, 2021
robwalch added a commit that referenced this pull request Dec 15, 2021
Resolves #2623 (Add CMAF CC support)
Resolves #4242 (Fix parsing multiple user data unregistered SEI)
Closes #4421 (Does hls.js support extracting SEI frame from videos?)
Fixes #4317 (Progressive mode is broken with fmp4 playback)
robwalch added a commit that referenced this pull request Dec 16, 2021
Resolves #2623 (Add CMAF CC support)
Resolves #4242 (Fix parsing multiple user data unregistered SEI)
Closes #4421 (Does hls.js support extracting SEI frame from videos?)
Fixes #4317 (Progressive mode is broken with fmp4 playback)
robwalch added a commit that referenced this pull request Dec 16, 2021
Resolves #2623 (Add CMAF CC support)
Resolves #4242 (Fix parsing multiple user data unregistered SEI)
Closes #4421 (Does hls.js support extracting SEI frame from videos?)
Fixes #4317 (Progressive mode is broken with fmp4 playback)
robwalch added a commit that referenced this pull request Jan 18, 2022
Resolves #2623 (Add CMAF CC support)
Resolves #4242 (Fix parsing multiple user data unregistered SEI)
Closes #4421 (Does hls.js support extracting SEI frame from videos?)
Fixes #4317 (Progressive mode is broken with fmp4 playback)
robwalch added a commit that referenced this pull request Jan 25, 2022
Resolves #2623 (Add CMAF CC support)
Resolves #4242 (Fix parsing multiple user data unregistered SEI)
Closes #4421 (Does hls.js support extracting SEI frame from videos?)
Fixes #4317 (Progressive mode is broken with fmp4 playback)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants