-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: fix missing load stats for LL-HLS #4283
Bugfix: fix missing load stats for LL-HLS #4283
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically closed because it has not had recent activity. If this issue is still valid, please ping a maintainer and ask them to label it accordingly. |
Why this PR didn't go through? It looks good to me |
This creates a new problem. It is not clear how to reproduce the issue described or how this fix is valid. stats are accumulated from loaders, which is why HLS.js copies stats from the (part) loader to the part. Please file an issue with steps to reproduce. I could not reproduce the issue following the details provided in this PR. |
Hi @Oleksandr0xB, Thanks for the fix. I confirmed the issue and have another way to fix it that involved always selecting parts to load from level.details.partList rather than reusing the same partList present when selecting the first part in a fragment. |
…ents and higher TTFB Fixes video-dev#3578 (special thanks to @Oleksandr0xB for submitting video-dev#4283) Fixes video-dev#3563 and Closes video-dev#3595 (special thanks to @kanongil)
* Improve bandwidth estimation and adaptive switching with smaller segments and higher TTFB Fixes #3578 (special thanks to @Oleksandr0xB for submitting #4283) Fixes #3563 and Closes #3595 (special thanks to @kanongil) * Load rate and loaded delay calculation fixes * Convert ttfbEstimate to seconds * Include main variant init segments in TTFB sampling * Use ttfb estimate in abandon rules down-switch timing
* Improve bandwidth estimation and adaptive switching with smaller segments and higher TTFB Fixes #3578 (special thanks to @Oleksandr0xB for submitting #4283) Fixes #3563 and Closes #3595 (special thanks to @kanongil) * Load rate and loaded delay calculation fixes * Convert ttfbEstimate to seconds * Include main variant init segments in TTFB sampling * Use ttfb estimate in abandon rules down-switch timing
This PR will...
Fix problem with missing load stats for LL-HLS.
Why is this Pull Request needed?
With missing stats ABR for LL-HLS usually stuck on lowers channels. This PR will fix it.
Problem with existing code is following.
hls.js/src/controller/level-helper.ts
Lines 260 to 268 in 1ea75a2
hls.js/src/loader/fragment-loader.ts
Lines 172 to 173 in 1ea75a2
As result ABR will use empty newPart stats.
Changing direction of assign fix this problem
Are there any points in the code the reviewer needs to double check?
Maybe the same logic can be applied to fragment loading stats
Resolves issues:
#3578
Checklist