Bugfix: CC of low latency streams not displayed correctly #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongfeih-es
changed the title
hongfeih-es
changed the title
robwalch
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix issue of CC of low latency streams not displayed correctly
Why is this Pull Request needed?
cea608parser will be reset when sn of currently loaded fragment is not as same as last sn + 1, which is wrong for low latency streams. For low latency case, parts of a segment is loaded with same sn, cea608parser shouldn't be reset.
hls.js/src/controller/timeline-controller.ts
Lines 429 to 433 in 1ea75a2
Are there any points in the code the reviewer needs to double check?
No.
Resolves issues:
#4297
Checklist