Bugfix/hardware accelerated decoding apple silicon #4412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpommers
force-pushed
the
bugfix/hardware-accelerated-decoding-apple-silicon
branch
2 times, most recently
from
966af9a
to
90df4bf
Compare
lpommers
added a commit
to wistia/hls.js
that referenced
this pull request
Nov 10, 2021
…on chips. See more at video-dev#4412, where this is going to be merged into the main project
robwalch
requested changes
Dec 2, 2021
…ts are not starting right at the beginning of the PES packet
lpommers
force-pushed
the
bugfix/hardware-accelerated-decoding-apple-silicon
branch
from
4e5fd2b
to
887bf2e
Compare
robwalch
approved these changes
Dec 3, 2021
littlespex
pushed a commit
to cbsinteractive/hls.js
that referenced
this pull request
Dec 9, 2022
Without an explicit size, some platforms render bitmap-based cues as 0x0. This effect was seen in Chrome on Mac in particular. This started with PR video-dev#4412, where we factored out regions into their own element. The TTML spec says that background images should fill their associated region, so this fixes the issue by making the div explicitly the size of its parent element (100% x 100%).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
stop removing the start delimiter bytes from the PES packet during demuxing if they overlap.
Why is this Pull Request needed?
This PR is needed because hardware accelerated decoding on Apple Silicon cannot properly decode the MPEG-TS stream when it has been manipulated in this manner.
Are there any points in the code the reviewer needs to double check?
mediafilesegmenterstreams to try and reproduce the original issue using an Intel Mac. I don't believe I was successful.tsdemuxer.tsand will see the specs fail. I've also tried to document that fact in the test stream description.I spoke with @mangui about trying to see if this change would solve the issue which led to this conditional being added, but without access to those broken streams, I was unable to fully do so. There is a comment (#3834 (comment)) from my bug report showing my inability to find this conditional being useful today.
Resolves issues:
#3834
Checklist