Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtitle loading after switching subtitles off and on #4457

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Dec 14, 2021

This PR will...

Fix subtitle loading after switching subtitles off and then on to a new track

Resolves issues:

Fixes #4345

Checklist

  • changes have been done against master branch, and PR does not conflict

@robwalch robwalch added this to the 1.1.2 milestone Dec 14, 2021
@OrenMe
Copy link
Collaborator

OrenMe commented Dec 14, 2021

Thanks @robwalch !

@robwalch robwalch requested a review from OrenMe December 14, 2021 20:08
@robwalch robwalch force-pushed the bugfix/subtitle-stream-controller-idle branch from 8ff5b7d to 554bad4 Compare December 14, 2021 21:06
@robwalch robwalch merged commit ad21302 into master Dec 14, 2021
@robwalch robwalch deleted the bugfix/subtitle-stream-controller-idle branch December 14, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtitles not loaded after switching between subtitle track A > subtitles off > subtitle track B
3 participants