Fix nudge retries happening one time fewer than nudgeRetry config
#4485
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
force-pushed
the
fix-nudge-retry-off-by-1
branch
from
4d85bea
to
f87291b
Compare
robwalch
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix nudge retries happening one time fewer than
nudgeRetryconfigWhy is this Pull Request needed?
It's one off.
I'm wondering if we should treat this as a breaking change and maybe just update the docs instead?
Or we could change the default from value from 3 to 2 so there's no behaviour change for people who haven't set the config option.
Or maybe it's fine. My concern is if people are expecting there to be X events and now there will be X + 1.
Checklist