fix: level playlist parse error of ProgramDateTime #4498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix level playlist parse error when
#EXT-X-PROGRAM-DATE-TIME
appear before#EXT-X-MAP
Why is this Pull Request needed?
When
#EXT-X-PROGRAM-DATE-TIME
appear before#EXT-X-MAP
,rawProgramDateTime
of currentInitSegment will be set:hls.js/src/loader/m3u8-parser.ts
Line 274 in 116e7cd
Then
rawProgramDateTime
of the following fragments will be set to samerawProgramDateTime
:hls.js/src/loader/m3u8-parser.ts
Lines 228 to 231 in 116e7cd
Thus,
programDateTime
will be set to wrong value in functionassignProgramDateTime
:hls.js/src/loader/m3u8-parser.ts
Lines 613 to 615 in 116e7cd
So
currentInitSegment.rawProgramDateTime
need to be cleared after set once.Are there any points in the code the reviewer needs to double check?
No.
Checklist