Make Opus sample entry lowercase #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2022
Closed
robwalch
approved these changes
Oct 6, 2022
robwalch
requested changes
Oct 6, 2022
There was a problem hiding this comment.
Please fix lint errors https://github.com/video-dev/hls.js/actions/runs/2673704013/jobs/4165078851
This commit violates RFC6381 + MP4RA ISO code list for compatibility with browsers and other players.
Chrome and Firefox accept `opus` codec only as lowercase despite ISO code has a capital O:
```
> MediaSource.isTypeSupported('audio/mp4; codecs="opus"')
true
> MediaSource.isTypeSupported('audio/mp4; codecs="Opus"')
false
```
No player plays an M3U8 with `CODECS="Opus"`, but some players do play an M3U8 with `CODECS="opus"`.
`codecs="opus"` is also playable in DASH.
stolen
force-pushed
the
opus-lowercase-code
branch
from
b3b7f76
to
3466027
Compare
|
@robwalch I don't understand what "Not a Contribution" means for me. |
|
@stolen you can ignore that it's an apache licensing related thing. |
robwalch
approved these changes
Oct 12, 2022
robwalch
pushed a commit
that referenced
this pull request
Oct 25, 2022
This commit violates RFC6381 + MP4RA ISO code list for compatibility with browsers and other players.
Chrome and Firefox accept `opus` codec only as lowercase despite ISO code has a capital O:
```
> MediaSource.isTypeSupported('audio/mp4; codecs="opus"')
true
> MediaSource.isTypeSupported('audio/mp4; codecs="Opus"')
false
```
No player plays an M3U8 with `CODECS="Opus"`, but some players do play an M3U8 with `CODECS="opus"`.
`codecs="opus"` is also playable in DASH.
littlespex
pushed a commit
to cbsinteractive/hls.js
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit violates RFC6381 + MP4RA ISO code list for compatibility with browsers and other players.
This PR will make hls.js accept
opuscodecChrome and Firefox accept
opuscodec only as lowercase despite ISO code has a capital O:No player plays an M3U8 with
CODECS="Opus", but some players do play an M3U8 withCODECS="opus".codecs="opus"is also playable in DASH.Why is this Pull Request needed?
Opus is modern open audio codec already used in Internet communications and it has a potential use in video streaming.
Browsers (I checked Firefox and Chrome) violate some specs and accept only lowercase codec for Opus:
Are there any points in the code the reviewer needs to double check?
no
Resolves issues:
#4527
Checklist