Bugfix/webvtt-parse: cue offset (subtitle stream without X-TIMESTAMP-MAP) #4557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something strange has happened with this branch, all the commits between the master seem to have been duplicated. Could you rebase this to a clean commit with your change? |
|
I spot-checked the deploy preview using the original stream that reported the issue and could not reproduce the captions being late. Additionally, I checked the BipBop stream with has timestamp maps, and all seemed to be well. Assuming we can get a clean source branch, I don't see any reason to not merge. |
mtoczko
force-pushed
the
bugfix/webvtt-parse-cueOffset
branch
from
14a7748
to
ed72063
Compare
done |
robwalch
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Removes unnecessary code, 1.x.x versions do not need this code, they already have the cueOffset calculation fixed
Why is this Pull Request needed?
subtitle stream without X-TIMESTAMP-MAP, has incorrect cue start/end time
Are there any points in the code the reviewer needs to double check?
Resolves issues:
#4500
Checklist