Update ID3 cues to span until playlist end, or next cue with same tag type (value.key) on cue append #4719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Update ID3 cues in timed metadata text tracks to span until the playlist end or until the start of the next cue with the same frame type.
Why is this Pull Request needed?
This change improves the handling of ID3 metadata for applications using metadata TextTrack active cues. Since ID3v2 frames have no duration or end time, cues should remain active until the HLS playlist's end or until another cue with the same ID3 frame type begins.
Are there any points in the code the reviewer needs to double check?
In Safari, DataCues are assigned an endTime of Infinity, but since HLS.js may use VTTCues, which must have finite start and end times, the current playlist end time was chosen to keep the number of active cues manageable. Applications wishing to modify the default endTime of new cues may do so on "cuechange".
Resolves issues:
Resolves #3879
Checklist