Bugfix: Handle single sample MPEG2-TS video segments #4794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
littlespex
pushed a commit
to cbsinteractive/hls.js
that referenced
this pull request
Dec 9, 2022
We require node v14+ and Java v11+ now. Closes video-dev#4721 Closes video-dev#4737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Keep track of last or average video sample duration in TS->MP4 remuxer, and use this value (or a default of 1/30s) when remuxing a single sample. Also allow a single video sample on remuxer flush to ensure all video samples in a segment are processed even if there is only one sample.
Why is this Pull Request needed?
Without this change HLS.js will not process single sample segments. We can encounter streams or discontinuity sequences that end with a single video sample or frame.
Are there any points in the code the reviewer needs to double check?
There is no way in the demuxer currently to determine duration of single sample or fps of media in a TS segment without comparing samples.
Resolves issues:
Fixes: #4783
Checklist