Make gap controller wait for active fragments while seeking #4806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Make the gap controller wait for active fragments that start before current position while seeking.
Why is this Pull Request needed?
When seeking to a point with 2 seconds (
MAX_START_GAP_JUMP
) before a buffered range, the gap-controller will seek to the start of that range without waiting for fragments to be loaded and appended that would fill the buffer. This change makes the gap controller wait so that rather than skipping ahead, it seeks to and plays the media from the main playlist at the initial seek point.Are there any points in the code the reviewer needs to double check?
Only active fragments from the stream-controller (main playlist) are considered. Alternate audio track fragments are not included in the check. Generally audio segments are smaller and are delivered ahead of video, but this might not always be the case, so passing in both could be a good future enhancement (once the stream controller can monitor the audio stream controller, or the gap controller operates with access to both).
Resolves issues:
Checklist