Bugfix: Use audio PTS over playlist time when aligned with video #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Align audio to video rather than trusting playlist offsets when remuxing MPEG2-TS audio and video samples at the same time.
Why is this Pull Request needed?
Long playlists with inaccurate durations can result in incorrect fragment start times. The mp4-remuxer was always using video timestamps in these cases, but for audio was not, leading to cases where appended AV did not even overlap after seeking hours into a playlist with this kind of drift (#4418).
With this fix, the media is appended correctly, even if it's not where it was expected to be based on playlist content.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #4418
Checklist