Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to use Node.js v16 #4821

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Aug 1, 2022

This PR will...

  • Update workflows to use Node.js v16.

Why is this Pull Request needed?

Testing functional test hosting in updated Node.js

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch
Copy link
Collaborator Author

robwalch commented Aug 1, 2022

@tjenkinson I was hoping that updating Node.js would resolve the issue with running functional tests on Safari with http-server - following up from #4812. I guess not.

tjenkinson
tjenkinson previously approved these changes Aug 2, 2022
Copy link
Member

@tjenkinson tjenkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to update to 16 anyway 👍

Don't have much time atm but can look into that error. Did you hear back from saucelabs?

@robwalch
Copy link
Collaborator Author

robwalch commented Aug 2, 2022

I did not hear back. It looks like a driver issue running the browser.executeAsyncScript call that kicks off the test:

  {
    "screenshot": null,
    "suggestion_values": [],
    "start_time": 1659385362.004201,
    "request": {
      "args": [
        "https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8",
        {}
      ],
      "script": "return (function (url, config) {\n    const callback = arguments[arguments.length - 1];\n    self.startStream(url, config, callback);\n    const video = self.video;\n\n    video.onloadeddata = function () {\n      callback({\n        code: 'loadeddata',\n        logs: self.logString\n      });\n    };\n  }).apply(null, arguments);"
    },
    "result": {
      "message": "POST /session/A8B8D1C7-3F28-4C6B-B2E1-826E5F550042/execute/async\nBuild info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:13:22.693Z'\nSystem info: host: 'itako757.prod.miso', ip: '10.125.1.55', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.15.4', java.version: '13.0.1'\nDriver info: driver.version: unknown",
      "error": "unknown command",
      "stackTrace": [
        {
          "className": "org.openqa.selenium.remote.http.AbstractHttpCommandCodec",
          "lineNumber": 261,
          "methodName": "decode",
          "fileName": "AbstractHttpCommandCodec.java"
        },

The request looks identical to passing tests on other platforms. My guess is the keyword self is an issue here. Let's see...

@robwalch robwalch changed the title Update workflows to use Node.js v16 Functional test fixes Aug 2, 2022
@robwalch
Copy link
Collaborator Author

robwalch commented Aug 3, 2022

The request looks identical to passing tests on other platforms. My guess is the keyword self is an issue here. Let's see...

That wasn't it. I'll roll back that change and merge the node.js update.

@robwalch robwalch force-pushed the task/workflows-update-nodejs-16 branch from 4e4760c to 6d4a029 Compare August 3, 2022 01:48
@robwalch robwalch merged commit 8f1384e into master Aug 4, 2022
@robwalch robwalch deleted the task/workflows-update-nodejs-16 branch August 4, 2022 01:35
@robwalch robwalch changed the title Functional test fixes Update workflows to use Node.js v16 Aug 4, 2022
@robwalch robwalch added this to the 1.2.1 milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants