fix safari on sauce labs: lock selenium-webdriver to 4.1.0 for now
#4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
force-pushed
the
fix-broken-safari-tests
branch
from
487fbc2
to
f6a511c
Compare
robwalch
reviewed
Aug 4, 2022
package.json
Outdated
| @@ -101,7 +101,7 @@ | |||
| "prettier": "2.7.1", | |||
| "promise-polyfill": "8.2.3", | |||
| "sauce-connect-launcher": "1.3.2", | |||
| "selenium-webdriver": "4.3.1", | |||
| "selenium-webdriver": "4.0.0", | |||
There was a problem hiding this comment.
it didn't actually fix it. Just trying a few different things
There was a problem hiding this comment.
ah wait yeh it's actual failures now 馃
There was a problem hiding this comment.
will do some more digging and try and figure out which version broke
|
ok it looks like it broke with 4.1.1, so something in SeleniumHQ/selenium@selenium-4.1.0...selenium-4.1.1-javascript |
tjenkinson
force-pushed
the
fix-broken-safari-tests
branch
from
7ebc98e
to
384cd5e
Compare
tjenkinson
changed the title
selenium-webdriver to 4.1.1 for now
to make safari on SauceLabs work
tjenkinson
force-pushed
the
fix-broken-safari-tests
branch
from
384cd5e
to
ecb2560
Compare
tjenkinson
changed the title
selenium-webdriver to 4.1.1 for nowselenium-webdriver to 4.1.0 for now
robwalch
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Lock
selenium-webdriverto 4.1.0 for now so that SauceLabs works with Safari. Also prevents PR's with new versions from being auto merged, which would happen given the safari tests are optional.Will open a ticket with sauce labs to see if they can explain why the newer versions are getting this error. Maybe they need to update the server on their end 馃し
Why is this Pull Request needed?
Fix safari tests.