Feature/determine text track kind based on CHARACTERISTICS #4850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
will set the text track kind to either
captions
orsubtitles
based on CHARACTERISTICS attribute in the MediaPlaylist for the track.Why is this Pull Request needed?
If a text tracks has
CHARACTERISTICS="public.accessibility.transcribes-spoken-dialog,public.accessibility.describes-music-and-sound
, the native video element in Safari will set thekind
property of the textTrack tocaptions
instead ofsubtitles
.Are there any points in the code the reviewer needs to double check?
hls.js/src/controller/timeline-controller.ts
Lines 225 to 245 in 79895a4
hls.js/src/controller/timeline-controller.ts
Lines 247 to 266 in 79895a4
Resolves issues:
Closes #2472
Checklist