Initial timestamps must be unsigned for tfdt v1 box #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
deleted the
bugfix/unsigned-track-fragment-base-decode-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Never use negative start times in m2ts remuxer.
Why is this Pull Request needed?
The remuxed mp4 output includes a tfdt box with base media decode timestamp which is expected to be an unsigned int(64) based on the box version of 1. This does not allow for negative values. The UA checks are not reliable enough to prevent us from using negative values in places where they could break playback.
Resolves issues:
Fixes #4893 #4899
Checklist