Level codec fixes for Dolby Vision and filtering of unknown codecs #4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed with levels where codecs are known Related to #4744
Closed
5 tasks
cjpillsbury
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Add Dolby Vision four CCs and filter out levels with unknown codecs mixed with levels with known codecs.
Why is this Pull Request needed?
This allows HLS.js to properly filter out levels with Dolby Vision codec strings in browser without support. Where these codecs are supported, SourceBuffers will be created with the correct mime-type strings (#4744).
In the case where HLS.js encounters unknown codecs (as was the case with dvh1 and dva1), since unknown codecs are not filtered using
isTypeSupported, they will be removed as long as there are levels that remain that passed the support check.Resolves issues:
Related to #4744 (This change may resolve that issue if it is an artifact of the SourceBuffer being created with the wrong codec string).
Other considerations:
This is a small change to improve variant filtering and SourceBuffer creation. It does not include robust HDR support with HDR/SDR selection or MediaCapabilities filtering. That will be covered by #2489 and other issues slated for v1.5.
Checklist