Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 608 captions on levels with CLOSED-CAPTIONS=NONE #4916

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 20, 2022

This PR will...

Disable 608 captions on variants with CLOSED-CAPTIONS=NONE attribute and value pair

Why is this Pull Request needed?

Spec compliance and Safari parity

Resolves issues:

Resolves #4913

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.2.4 milestone Sep 20, 2022
@robwalch robwalch merged commit c7b01b7 into master Sep 20, 2022
@robwalch robwalch deleted the bugfix/closed-captions-none branch September 20, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLOSED-CAPTIONS=NONE seems to have no effect
1 participant