Bugfix: Live Playlist Reload Interval #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Change the reload interval of a playlist to match the HLS spec. The playlist will now reload after waiting a timeout period equal to the target duration if there is an update, or equal to half of the target duration if there is no update to the playlist.
Why is this Pull Request needed?
The browser was previously requested updates to the playlist too frequently, which can put extra load on the server and is not in accordance with the HLS spec.
Are there any points in the code the reviewer needs to double check?
Verify that
averagetargetdurationis okay to be removed.Resolves issues:
#4915
Checklist