tsdemuxer: remove redundant discardEPB call & impl #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to call discardEPB on the data passed to parseSEIMessageFromNALu since it's performed inside function. removed the duplicate implementation discardEPB from tsdemuxer, and exported the mp4-tools implementation instead.
3 tasks
robwalch
approved these changes
Oct 25, 2022
robwalch
pushed a commit
that referenced
this pull request
Oct 25, 2022
no need to call discardEPB on the data passed to parseSEIMessageFromNALu since it's performed inside function. removed the duplicate implementation discardEPB from tsdemuxer, and exported the mp4-tools implementation instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to call discardEPB on the data passed to parseSEIMessageFromNALu since it's performed inside function.
removed the duplicate implementation discardEPB from tsdemuxer, and exported the mp4-tools implementation instead.
This PR will...
Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist