Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fragment LoadStats total set to 0 with progressive: true #5054

Merged
merged 1 commit into from Nov 28, 2022
Merged

Bugfix: Fragment LoadStats total set to 0 with progressive: true #5054

merged 1 commit into from Nov 28, 2022

Conversation

robwalch
Copy link
Collaborator

This PR will...

Prevent loaded and total bytes stats from being overwritten with 0 when the player is configured to load and append progressively with progressive: true.

Why is this Pull Request needed?

These stats are essential to establishing a bandwidth estimate.

Resolves issues:

Fixes #5050

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.2.8 milestone Nov 23, 2022
@robwalch robwalch mentioned this pull request Nov 23, 2022
Closed
5 tasks
@robwalch robwalch merged commit 31fd1f5 into master Nov 28, 2022
@robwalch robwalch deleted the bugfix/progressive-stats-total branch November 28, 2022 22:03
robwalch added a commit that referenced this pull request Nov 28, 2022
@robwalch
Bugfix: Fragment LoadStats total set to 0 with progressive: true (#…
fb7a4c5 
…5054)

Fixes #5050

Co-authored-by: Rob Walch <rob@jwplayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjamie itsjamie itsjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.8
Development

Successfully merging this pull request may close these issues.

LoadStats properties loaded and total is 0 for a download fragment when using FetchLoader
2 participants
@robwalch @itsjamie