Eagerly match segments without tolerance offset #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlespex
previously approved these changes
Dec 6, 2022
This was referenced Dec 6, 2022
robwalch
force-pushed
the
bugfix/fragment-tolerance
branch
from
8eb0414
to
bacfffe
Compare
5 tasks
3 tasks
infocity-hirata
pushed a commit
to INFOCITY/hls.js
that referenced
this pull request
Jun 30, 2023
* Eagerly match segments without tolerance offset Fixes video-dev#4919 * Maintain expected `fragPrevious` behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Make
fragmentWithinToleranceTesteagerly return a match on an exact match before checking for a match with tolerance.Why is this Pull Request needed?
This is needed to not skip over small segments or segments adjacent to small segments.
Resolves issues:
Fixes #4919
Checklist